Update to follow draft-14#263
Closed
tobbee wants to merge 4 commits intomengelbart:mainfrom
Closed
Conversation
- Rename SUBSCRIBE_DONE to PUBLISH_DONE (0x0b) - Rename ANNOUNCE family to PUBLISH_NAMESPACE family: - ANNOUNCE -> PUBLISH_NAMESPACE (0x06) - ANNOUNCE_OK -> PUBLISH_NAMESPACE_OK (0x07) - ANNOUNCE_ERROR -> PUBLISH_NAMESPACE_ERROR (0x08) - UNANNOUNCE -> PUBLISH_NAMESPACE_DONE (0x09) - ANNOUNCE_CANCEL -> PUBLISH_NAMESPACE_CANCEL (0x0c) - Rename SUBSCRIBE_ANNOUNCES family to SUBSCRIBE_NAMESPACE family: - SUBSCRIBE_ANNOUNCES -> SUBSCRIBE_NAMESPACE (0x11) - SUBSCRIBE_ANNOUNCES_OK -> SUBSCRIBE_NAMESPACE_OK (0x12) - SUBSCRIBE_ANNOUNCES_ERROR -> SUBSCRIBE_NAMESPACE_ERROR (0x13) - UNSUBSCRIBE_ANNOUNCES -> UNSUBSCRIBE_NAMESPACE (0x14) - Rename TRACK_STATUS messages for consistency: - TRACK_STATUS_REQUEST -> TRACK_STATUS (0x0d) - TRACK_STATUS -> TRACK_STATUS_OK (0x0e) - Add SubscriptionRequestID field to SUBSCRIBE_UPDATE message
Per draft-14, SUBSCRIBE_UPDATE increments the request ID counter and is subject to flow control. Add validation of the new Request ID against localMaxRequestID to enforce this.
300af47 to
c6acce0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR should be a complete update to draft-14 syntax including renaming, changes of protocol version, and checking the double requestIDs in SUBSCRIBE_UPDATE.
Compared to #254, the renaming should be more complete. Here is a Claude analysis of the differences:
Both commits implement draft-14 message naming updates, but commit 23906d8 (your fork) has several important additions and fixes compared to commit 31744d4 (upstream):
Key Differences
Your commit (23906d8):
Upstream commit (31744d4):
This is a breaking protocol change that better aligns with draft-14's request/response pattern.
Your commit (23906d8):
Upstream commit (31744d4):
Your commit (23906d8):
Upstream commit (31744d4):
Your commit:
Both commits rename the handler methods from:
But your commit has more complete implementation in session.go with proper RequestID handling.